Fix ArduinoOTA and put OTA setup in dedicated function #2

Open

Lomanic wants to merge 1 commits from Lomanic/PiedThon:arduinoota-fix into master

pull from: Lomanic/PiedThon:arduinoota-fix

merge into: jeanjack:master

jeanjack:master

Conversation 1 Commits 1 Files Changed 1 +37 -33

Lomanic commented 2019-11-26 22:47:48 +00:00

Contributor

Copy Link

No description provided.

Lomanic commented 2019-11-27 19:06:10 +00:00

Author

Contributor

Copy Link

Don't merge right now, this might not be a proper fix, as mDNS should already be handled by ArduinoOTA.handle(). It looks like some weird bug like esp8266/Arduino#6205. To be tested on another webduino maybe?

Don't merge right now, this might not be a proper fix, as mDNS should already be handled by [`ArduinoOTA.handle()`](https://github.com/esp8266/Arduino/blob/ec7ae4ed44d82c411100e01de67bc4902b5276b1/libraries/ArduinoOTA/ArduinoOTA.cpp#L370). It looks like some weird bug like [esp8266/Arduino#6205](https://github.com/esp8266/Arduino/issues/6205). To be tested on another webduino maybe?

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u arduinoota-fix:Lomanic-arduinoota-fix

git checkout Lomanic-arduinoota-fix

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No Label

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jeanjack/PiedThon#2

No description provided.