jeanjack/PiedThon
1
0
Fork 1
Code Issues Pull requests 1 Releases Wiki Activity

Fix ArduinoOTA and put OTA setup in dedicated function #2

Open
Lomanic wants to merge 1 commit from Lomanic/PiedThon:arduinoota-fix into master
pull from: Lomanic/PiedThon:arduinoota-fix
merge into: jeanjack:master
Conversation 1 Commits 1 Files changed 1 +37 -33
Lomanic commented 2019-11-26 22:47:48 +00:00
Contributor
Copy link
No description provided.
Lomanic commented 2019-11-27 19:06:10 +00:00
Author
Contributor
Copy link

Don't merge right now, this might not be a proper fix, as mDNS should already be handled by ArduinoOTA.handle(). It looks like some weird bug like esp8266/Arduino#6205. To be tested on another webduino maybe?

Don't merge right now, this might not be a proper fix, as mDNS should already be handled by [`ArduinoOTA.handle()`](https://github.com/esp8266/Arduino/blob/ec7ae4ed44d82c411100e01de67bc4902b5276b1/libraries/ArduinoOTA/ArduinoOTA.cpp#L370). It looks like some weird bug like [esp8266/Arduino#6205](https://github.com/esp8266/Arduino/issues/6205). To be tested on another webduino maybe?
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u arduinoota-fix:Lomanic-arduinoota-fix
git checkout Lomanic-arduinoota-fix

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout master
git merge --no-ff Lomanic-arduinoota-fix
git checkout Lomanic-arduinoota-fix
git rebase master
git checkout master
git merge --ff-only Lomanic-arduinoota-fix
git checkout Lomanic-arduinoota-fix
git rebase master
git checkout master
git merge --no-ff Lomanic-arduinoota-fix
git checkout master
git merge --squash Lomanic-arduinoota-fix
git checkout master
git merge --ff-only Lomanic-arduinoota-fix
git checkout master
git merge Lomanic-arduinoota-fix
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jeanjack/PiedThon#2
No description provided.
Delete branch "Lomanic/PiedThon:arduinoota-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?