From cade09aceb329ed2803b79484f9351c6b89aafd8 Mon Sep 17 00:00:00 2001 From: Austin Huang Date: Tue, 6 Jul 2021 11:23:53 -0400 Subject: [PATCH] remove SHOW_CAPTION setting --- .../fragments/settings/PostPreferencesFragment.java | 10 ---------- .../instagrabber/fragments/settings/PreferenceKeys.kt | 2 +- .../java/awais/instagrabber/utils/SettingsHelper.kt | 2 +- 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/app/src/main/java/awais/instagrabber/fragments/settings/PostPreferencesFragment.java b/app/src/main/java/awais/instagrabber/fragments/settings/PostPreferencesFragment.java index b1db2e40..4c91407f 100644 --- a/app/src/main/java/awais/instagrabber/fragments/settings/PostPreferencesFragment.java +++ b/app/src/main/java/awais/instagrabber/fragments/settings/PostPreferencesFragment.java @@ -18,7 +18,6 @@ public class PostPreferencesFragment extends BasePreferencesFragment { // generalCategory.addPreference(getAutoPlayVideosPreference(context)); screen.addPreference(getBackgroundPlayPreference(context)); screen.addPreference(getAlwaysMuteVideosPreference(context)); - screen.addPreference(getShowCaptionPreference(context)); screen.addPreference(getToggleKeywordFilterPreference(context)); screen.addPreference(getEditKeywordFilterPreference(context)); } @@ -48,15 +47,6 @@ public class PostPreferencesFragment extends BasePreferencesFragment { return preference; } - private Preference getShowCaptionPreference(@NonNull final Context context) { - final SwitchPreferenceCompat preference = new SwitchPreferenceCompat(context); - preference.setKey(PreferenceKeys.SHOW_CAPTIONS); - preference.setDefaultValue(true); - preference.setTitle(R.string.post_viewer_show_captions); - preference.setIconSpaceReserved(false); - return preference; - } - private Preference getToggleKeywordFilterPreference(@NonNull final Context context) { final SwitchPreferenceCompat preference = new SwitchPreferenceCompat(context); preference.setKey(PreferenceKeys.TOGGLE_KEYWORD_FILTER); diff --git a/app/src/main/java/awais/instagrabber/fragments/settings/PreferenceKeys.kt b/app/src/main/java/awais/instagrabber/fragments/settings/PreferenceKeys.kt index a2a9649d..415bd829 100644 --- a/app/src/main/java/awais/instagrabber/fragments/settings/PreferenceKeys.kt +++ b/app/src/main/java/awais/instagrabber/fragments/settings/PreferenceKeys.kt @@ -32,7 +32,7 @@ object PreferenceKeys { const val PLAY_IN_BACKGROUND = "play_in_background" const val AUTOPLAY_VIDEOS_STORIES = "autoplay_videos" const val MUTED_VIDEOS = "muted_videos" - const val SHOW_CAPTIONS = "show_captions" +// const val SHOW_CAPTIONS = "show_captions" const val CUSTOM_DATE_TIME_FORMAT_ENABLED = "data_time_custom_enabled" const val SWAP_DATE_TIME_FORMAT_ENABLED = "swap_date_time_enabled" const val MARK_AS_SEEN = "mark_as_seen" diff --git a/app/src/main/java/awais/instagrabber/utils/SettingsHelper.kt b/app/src/main/java/awais/instagrabber/utils/SettingsHelper.kt index 57f93af3..8c6905cd 100755 --- a/app/src/main/java/awais/instagrabber/utils/SettingsHelper.kt +++ b/app/src/main/java/awais/instagrabber/utils/SettingsHelper.kt @@ -119,7 +119,7 @@ class SettingsHelper(context: Context) { PreferenceKeys.DOWNLOAD_PREPEND_USER_NAME, PreferenceKeys.AUTOPLAY_VIDEOS_STORIES, PreferenceKeys.MUTED_VIDEOS, - PreferenceKeys.SHOW_CAPTIONS, +// PreferenceKeys.SHOW_CAPTIONS, PreferenceKeys.CUSTOM_DATE_TIME_FORMAT_ENABLED, PreferenceKeys.MARK_AS_SEEN, PreferenceKeys.DM_MARK_AS_SEEN,